Skip to content

[PM-35305] Add desktop-ui-settings-dialog flag#7491

Merged
Hinton merged 1 commit intomainfrom
desktop-ui-settinngs
Apr 24, 2026
Merged

[PM-35305] Add desktop-ui-settings-dialog flag#7491
Hinton merged 1 commit intomainfrom
desktop-ui-settinngs

Conversation

@Hinton
Copy link
Copy Markdown
Member

@Hinton Hinton commented Apr 17, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35305

📔 Objective

Adds a feature flag to be used by the new settings dialog in desktop

📸 Screenshots

@Hinton Hinton requested review from a team and BryanCunningham April 17, 2026 13:33
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details2d5a29f1-bce7-4ff7-ad68-cc6a4ec95c0d

Great job! No new security vulnerabilities introduced in this pull request

@Hinton Hinton merged commit 0230b83 into main Apr 24, 2026
44 checks passed
@Hinton Hinton deleted the desktop-ui-settinngs branch April 24, 2026 10:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.08%. Comparing base (914d412) to head (79adedc).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7491      +/-   ##
==========================================
- Coverage   59.08%   59.08%   -0.01%     
==========================================
  Files        2078     2078              
  Lines       91488    91488              
  Branches     8135     8135              
==========================================
- Hits        54053    54052       -1     
- Misses      35507    35508       +1     
  Partials     1928     1928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants